If a session is rotate in the middle of a server side rendering then some random portions of requests made on the server side will fail with a session taken error as the server is not going to update the cookies of the client during these requests. To avoid this pitfall extend the expiry time of sessions to be 10 seconds after the session has been rotated. This is accomplished by introducing a new timestamp on sessions called the rotateAt at time alongside the expiresAt time. Sessions used after rotateAt that haven't been rotated get rotated into a new session and the existing session gets the expiresAt time set to 10 seconds in the future. Sessions that are past the expiredAt time have no access. This makes the logic around session expiry simpler, and also makes it possible to audit when a session got rotated, and to mark sessions as expired without a chance to rotate to a new session without having to resort to a finished flag.
61 lines
1.7 KiB
TypeScript
61 lines
1.7 KiB
TypeScript
/*
|
|
SPDX-FileCopyrightText: © 2025 Hornwitser <code@hornwitser.no>
|
|
SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
import {
|
|
readUsers, readSessions, readSubscriptions,
|
|
writeUsers, writeSessions, writeSubscriptions,
|
|
} from "~/server/database";
|
|
import { broadcastEvent, cancelAccountStreams } from "~/server/streams";
|
|
|
|
export default defineEventHandler(async (event) => {
|
|
const serverSession = await requireServerSessionWithUser(event);
|
|
let users = await readUsers();
|
|
|
|
// Expire sessions for this user
|
|
const expiredSessionIds = new Set<number>();
|
|
let sessions = await readSessions();
|
|
const nowMs = Date.now();
|
|
for (const session of sessions) {
|
|
if (
|
|
session.successor !== undefined
|
|
&& (session.expiresAtMs === undefined || session.expiresAtMs < nowMs)
|
|
&& session.accountId === serverSession.accountId
|
|
) {
|
|
session.expiresAtMs = nowMs;
|
|
broadcastEvent({
|
|
type: "session-expired",
|
|
sessionId: session.id,
|
|
});
|
|
expiredSessionIds.add(session.id);
|
|
}
|
|
}
|
|
cancelAccountStreams(serverSession.accountId);
|
|
await writeSessions(sessions);
|
|
await deleteCookie(event, "session");
|
|
|
|
// Remove subscriptions for this user
|
|
let subscriptions = await readSubscriptions();
|
|
subscriptions = subscriptions.filter(
|
|
subscription => !expiredSessionIds.has(subscription.sessionId)
|
|
);
|
|
await writeSubscriptions(subscriptions);
|
|
|
|
// Remove the user
|
|
const account = users.find(user => user.id === serverSession.accountId)!;
|
|
const now = new Date(nowMs).toISOString();
|
|
account.deleted = true;
|
|
account.updatedAt = now;
|
|
await writeUsers(users);
|
|
await broadcastEvent({
|
|
type: "user-update",
|
|
data: {
|
|
id: account.id,
|
|
updatedAt: now,
|
|
deleted: true,
|
|
}
|
|
});
|
|
|
|
// Update Schedule counts.
|
|
await updateScheduleInterestedCounts(users);
|
|
})
|